update uberspace-nextcloud-installer.sh

uberspace-nextcloud-installer.sh

@@ -13,12 +13,17 @@ function install_nextcloud
   # using bash substring syntax to remove the 9 characters "password="
   MYSQL_PASSWORD=${MYSQL_PASSWORD_STR:9}
 
-  rm ~/html/nocontent.html
+  if [ -e ~/html/nocontent.html ]
-  cd ~/html || exit 
+  then rm ~/html/nocontent.html
+  fi
+  # shellcheck disable=2088
+  if [ "$(ls --almost-all ~/html/)" ]; then echo '~/html is not empty, abort!'; exit 1; fi
+  cd ~/html
   echo "Downloading Nextcloud to ~/html/"
-  curl https://download.nextcloud.com/server/releases/latest.tar.bz2 |
+  curl --progress-bar https://download.nextcloud.com/server/releases/latest.tar.bz2 |
     tar -xjf - --strip-components=1
   mysql --verbose --execute="CREATE DATABASE ${USER}_nextcloud"
+  echo "Installing Nextcloud"
   php ~/html/occ maintenance:install \
     --admin-user "${NEXTCLOUD_ADMIN_USER}" \
     --admin-pass "${NEXTCLOUD_ADMIN_PASS}" \
@@ -63,18 +68,9 @@ function setup_domains
 {
   echo "You currently have configured the following domains:"
   uberspace web domain list
-  while true
+  if yes-no_question "Do you want to add another domain to the web configuration of your uberspace?"
-  do
+  then add_domain
-  read -r -p "Do you want to add another domain to the web configuration of your uberspace? (y/n) " ANSWER
+  fi
-  case $ANSWER in
-    [Yy]* | [Jj]* )
-        add_domain
-      break;;
-    [Nn]* )
-      break;;
-    * ) echo "Please answer yes or no. ";;
-  esac
-  done
 }
 
 function add_domain
@@ -197,29 +193,42 @@ end_of_content
   chmod +x ~/bin/nextcloud-update
 }
 
-function ask_if_fresh_uberspace
+function yes-no_question
 {
-  echo "This script tries to install the latest release of Nextcloud"
+  local question=$1
-  echo "but it is tested for Nextcloud 23 on Uberspace 7.12.0"
-  echo "and assumes a newly created uberspace with default settings."
-  echo "Do not run this script if you already use your Uberspace for other apps!"
   while true
   do
-  read -r -p "Do you want to execute this installer for Nextcloud? (y/n) " ANSWER
+  read -r -p "$question (y/n) " ANSWER
   case $ANSWER in
     [Yy]* | [Jj]* )
-        install_nextcloud
+      return 0
-      break;;
+      ;;
     [Nn]* )
-      break;;
+      return 1
+      ;;
     * ) echo "Please answer yes or no. ";;
   esac
   done
 }
 
+function set_critical_section { set -o pipefail -o errexit; }
+function unset_critical_section { set +o pipefail +o errexit; }
+
 function main
 {
-  ask_if_fresh_uberspace
+  set_critical_section
+
+  echo "This script tries to install the latest release of Nextcloud"
+  echo "but it is tested for Nextcloud 23 on Uberspace 7.12.0"
+  echo "and assumes a newly created Uberspace with default settings."
+  echo "Do not run this script if you already use your Uberspace for other apps!"
+
+  if yes-no_question "Do you want to execute this installer for Nextcloud?"
+  then install_nextcloud
+  fi
+
+  unset_critical_section
 }
 
 main "$@"
+exit $?